-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Switch custom webpack build step to ember-auto-import #159
feat: Switch custom webpack build step to ember-auto-import #159
Conversation
94fda79
to
50a1a7b
Compare
aeeffaa
to
662c563
Compare
autoImport: { | ||
webpack: { | ||
module: { | ||
rules: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only needed for 0.13.1
& 0.13.2
. This issue does not exist in <= 0.13.0
and >= 14.0.0-rc.1
. Verified configuration is safe for all versions of graphql-js
.
662c563
to
e671824
Compare
e671824
to
14dc458
Compare
@bgentry friendly ping. Let me know if there is anything I can do. |
Thanks @jasonmit! The blocker remains that I want to deprecate the old import paths in a release before the major upgrade. So if you’re able to help with that it would be 🙏🏻 I guess another option would be to make a new branch for 1.x, then merge this and release a 2.0 beta that doesn’t yet include the deprecations. So I could do that pretty soon if nobody is able to help with #156 |
14dc458
to
fdaa49e
Compare
Any plans on getting this merged/released soon? |
@josemarluedke yep, coming today, sorry for the long delay! |
One thing that appears to have been lost with this PR is that the readme no longer explains how to import additional packages. Since folks are likely coming from 1.x where this is a bundled feature, maybe we should explain what they get out-of-the-box and show an example or at least link to ember-auto-import for how to get additional Apollo-related packages loaded? Can anybody PR that small doc fix today? Then I'll publish a v2.x beta. Thanks so much for this PR @jasonmit 👏 sorry for how long this took to ship 😞 |
fixes #145, #152
Side note, would much appreciate a beta or an rc tag once this is merged. Will enable me to get off my fork that hacked together engine support.