-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change RepetitionTime definition to the same one as DICOM field 0018,0080 #18
Comments
@Gilles86 wrote:
Note that for inversion recovery sequences (e.g., MP(2)RAGE), this corresponds to the time between inversion pulses. For GRE sequences (i.e., FLASH), this corresponds to the time between excitations. Unfortunately, the much-used MP(2)RAGE sequences consists of inversion pulses interspersed with GRE readout blocks. To calculate quantities like T1 from a set of MP2RAGE images, we need both the time between inversion pulses and the time between excitations in the subsequent GRE blocks. Maybe we should include an additional "ExcitationRepetitionTime"-field for that? One alternative would be to deduce this time between excitations using the number of k-space lines, acceleration, and the TotalReadoutTime, but this seems tricky to me... |
@tiborauer wrote:
There are two different versions of 0018,0080: http://dicomlookup.com/lookup.asp?sw=Tnumber&q=(0018,0080)
|
@tiborauer wrote:
Therefore, I propose the second definition and making it mandatory for all (also for BOLD). It should also replace RepetitionTime 'patches' (e.g. RepetitionTimeExcitation for structural) in BIDS 1. |
@tsalo, I think you quote yourself and not me. :) Otherwise, I agree. |
@tiborauer The quote is yours from the BIDS 2.0 doc, but it's from July 20, 2018. |
Oh, I see. I almost forgot that document. It is great to see its resurrection. I think I actually wrote everything else but the one in the quote in the two comments. Do not you want me to paste them properly capture provenance? :D |
You wrote the original suggestion? I'll update the "Original Authors" with you instead of Harms if so. |
See my suggestions here |
Ah, I see. The way I've written these issues, the quoted parts are quotes from previous comments to retain threads. The non-quoted part is what you wrote. This is just because GitHub issues don't thread the way Google Doc comments do. |
@tiborauer do you know if the changes in BEP001 encompass this? I recall there being something about redefining RepetitionTime, but I don't know if it's the same definition as from the DICOM standard. |
Partially. As you can see here, BEP001 keep the original definition but expands on the one suggested here (i.e. "the period of time in msec between the beginning of a pulse sequence and the beginning of the succeeding (essentially identical) pulse sequence"). However, it also defines two 'patches', as you can see here. |
Thanks! Okay, so it seems like BEP001 provides an intermediate solution, in which case this proposal is still relevant for 2.0. |
Current definition of RepetitionTime in BIDS is not the same as the one in DICOM which might cause confusion. The new definition would be:
RepetitionTime would also not be mandatory for _bold files and it’s previous role would be replaced by new mandatory TemporalResolution field or (similar TBD) field defined as:
Relevant discussion:
https://groups.google.com/d/msg/bids-discussion/MLUqmcD1XSY/_lMkr00yAwAJ
https://groups.google.com/d/msg/bids-discussion/wtolT5qPjy0/k2avH_1mCAAJ
Original authors: @mharms
The text was updated successfully, but these errors were encountered: