From 2f946878e4b50a8af40f6f5e38a22e5e669bb99f Mon Sep 17 00:00:00 2001
From: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
Date: Fri, 24 Mar 2023 11:05:29 +0100
Subject: [PATCH] [FIX] Clarify that dataset_description.Genetics object is
 required for genetics data (#1442)

* [FIX] Clarify that dataset_description.Genetics object is required for genetics data

also clarify that Genetics.Dataset is required if Genetics is supplied

* clarify: info on data is supplied, not data itself

* Update src/modality-specific-files/genetic-descriptor.md

* list required first
---
 src/modality-specific-files/genetic-descriptor.md |  5 +++--
 src/schema/objects/metadata.yaml                  | 13 +++++++------
 2 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/src/modality-specific-files/genetic-descriptor.md b/src/modality-specific-files/genetic-descriptor.md
index a8438611c1..a087b04d1c 100644
--- a/src/modality-specific-files/genetic-descriptor.md
+++ b/src/modality-specific-files/genetic-descriptor.md
@@ -19,11 +19,12 @@ and can be used for practical guidance when curating a new dataset.
 
 ## Dataset Description
 
-Genetic descriptors are encoded as an additional, OPTIONAL entry in the
+If information on associated genetic data is supplied as part of a BIDS dataset,
+these "genetic descriptors" are encoded as an additional, REQUIRED entry in the
 [`dataset_description.json`](../modality-agnostic-files.md#dataset_descriptionjson)
 file.
 
-Datasets linked to a genetic database entry include the following REQUIRED or OPTIONAL
+Datasets linked to a genetic database entry include the following REQUIRED and OPTIONAL
 keys in the `Genetics` sub-[object][] of `dataset_description.json`:
 
 <!-- This block generates a table describing subfields within a metadata field.
diff --git a/src/schema/objects/metadata.yaml b/src/schema/objects/metadata.yaml
index ea83bd2ca7..c441969f93 100644
--- a/src/schema/objects/metadata.yaml
+++ b/src/schema/objects/metadata.yaml
@@ -1144,19 +1144,20 @@ Genetics:
   description: |
     An object containing information about the genetics descriptor.
   type: object
+  required_fields: [Dataset]
   properties:
-    Database:
-      name: Database
+    Dataset:
+      name: Dataset
       description: |
         [URI](SPEC_ROOT/common-principles.md#uniform-resource-indicator)
-        of database where the dataset is hosted.
+        where data can be retrieved.
       type: string
       format: uri
-    Dataset:
-      name: Dataset
+    Database:
+      name: Database
       description: |
         [URI](SPEC_ROOT/common-principles.md#uniform-resource-indicator)
-        where data can be retrieved.
+        of database where the dataset is hosted.
       type: string
       format: uri
     Descriptors: