Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task metadata for PET #1188

Closed
Remi-Gau opened this issue Aug 7, 2022 · 5 comments · Fixed by #1196
Closed

Task metadata for PET #1188

Remi-Gau opened this issue Aug 7, 2022 · 5 comments · Fixed by #1196

Comments

@Remi-Gau
Copy link
Collaborator

Remi-Gau commented Aug 7, 2022

There seems to be no mention of the typical metadata usually associated with the task entity for PET (TaskName, Instructions, TaskDescription...).

Cannot recall if this was intentional or overlooked?

@melanieganz @mnoergaard

Any idea?

@melanieganz
Copy link
Contributor

Uh, good catch. I guess this was overlooked. @mnoergaard and I will be on fixing it.

@mnoergaard
Copy link
Collaborator

This was intentional at the time because it would require a long description of a task from the fMRI section of BIDS to be present in the PET BIDS section. Back then, we agreed to keep it out for now because 99% of PET data is rest (i.e. no task), and it seemed slightly confusing to include. But maybe we should consider to add it. It is currently allowed (according to the validator) to include the task entity for PET data.

@Remi-Gau
Copy link
Collaborator Author

This was intentional at the time because it would require a long description of a task from the fMRI section of BIDS to be present in the PET BIDS section. Back then, we agreed to keep it out for now because 99% of PET data is rest (i.e. no task), and it seemed slightly confusing to include. But maybe we should consider to add it. It is currently allowed (according to the validator) to include the task entity for PET data.

ah yes. I now remember we had this discussion. The task being present in so many datatypes leads to an amount of repeats across sections that irks me to no end, so I hear you. Still planning to do some refactoring of this to remove duplications at one point.

I can draft something short and you let me know: I cared more about saying explicitly what metadata could be added.

@mnoergaard
Copy link
Collaborator

That would be great, @Remi-Gau - thanks!

@Remi-Gau
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants