-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow microseconds in scans file datetimes #469
Comments
Seems reasonable. I can't find an authoritative reference, but it seems that in Unix land fractional seconds (separated by a period) is preferred. |
as long as we stay within RFC3339 formatting, I think that it's a good idea to allow for microseconds 👍 |
After looking through RFC3339, it looks like it's optional to include fractional seconds, so that should be okay. I think, for the specification, we just need to prescribe a specific number of digits for consistency. Python's |
I had a quick look as well and apparently neither RFC3339 nor ISO 8601 prescribe a number of decimal points for the fractional seconds. I am personally fine with 6, because it seems unrealistic that any application would need to be more precise than that. What do you think @nicholst ? If we are prescribing a number of decimal points for consistency, we might as well prescribe the use of |
I'm for prescribing |
Thank you both for working through it. I'll open a PR ASAP. |
+1 on arbitrary precision after |
This is related to nipy/heudiconv#447, nipy/heudiconv#451, and physiopy/phys2bids#219. Currently, the
_scans.tsv
file only allowsacq_time
with resolution down to the second. For the purposes of increased accuracy and to make it easier to synchronize scan data with simultaneously-acquired data from other modalities (e.g., physio data), it would be helpful if scans files'acq_time
column allowed (but didn't require) microseconds as well. Soacq_time
could be2009-06-15T13:45:30
or2009-06-15T13:45:30.500000
.The text was updated successfully, but these errors were encountered: