-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RepetitionTime type in bold.json not specified. #516
Comments
I would say it should be a number. |
@sappelhoff - here is one example issue, but could be generalized. @yarikoptic and @dbkeator - this should also tie in with more formalism updates to schemas. This come up in general for other contexts like echo time, flip angle, etc.,. where we don't specify either data types or units in many cases. |
thanks @satra. Crosslink for other readers: #508 (comment) We'll discuss this in tomorrows Maintainers meeting and act soon :-) |
closed by #605 |
bids-validator expects these to be a 'number' in the json schema for bold.json but the spec doesn't definitively say they can't be a string:
https://bids-specification.readthedocs.io/en/stable/04-modality-specific-files/01-magnetic-resonance-imaging-data.html#required-fields
bids-standard/bids-validator#674 shows that people have used strings for RepetitionTime before.
Should I update the schema in the validator to allow strings or should the specification be updated to enforce a specific type?
The text was updated successfully, but these errors were encountered: