Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RepetitionTime type in bold.json not specified. #516

Closed
rwblair opened this issue Jun 26, 2020 · 4 comments
Closed

RepetitionTime type in bold.json not specified. #516

rwblair opened this issue Jun 26, 2020 · 4 comments

Comments

@rwblair
Copy link
Member

rwblair commented Jun 26, 2020

bids-validator expects these to be a 'number' in the json schema for bold.json but the spec doesn't definitively say they can't be a string:

https://bids-specification.readthedocs.io/en/stable/04-modality-specific-files/01-magnetic-resonance-imaging-data.html#required-fields

bids-standard/bids-validator#674 shows that people have used strings for RepetitionTime before.

Should I update the schema in the validator to allow strings or should the specification be updated to enforce a specific type?

@effigies
Copy link
Collaborator

I would say it should be a number.

@satra
Copy link
Collaborator

satra commented Jul 20, 2020

@sappelhoff - here is one example issue, but could be generalized.

@yarikoptic and @dbkeator - this should also tie in with more formalism updates to schemas. This come up in general for other contexts like echo time, flip angle, etc.,. where we don't specify either data types or units in many cases.

@sappelhoff
Copy link
Member

thanks @satra. Crosslink for other readers: #508 (comment)

We'll discuss this in tomorrows Maintainers meeting and act soon :-)

@sappelhoff
Copy link
Member

closed by #605

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants