Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] PDF build on CI raises warnings: duplicate links #766

Closed
sappelhoff opened this issue Mar 25, 2021 · 4 comments
Closed

[INFRA] PDF build on CI raises warnings: duplicate links #766

sappelhoff opened this issue Mar 25, 2021 · 4 comments
Labels
formatting Aesthetics and formatting of the spec

Comments

@sappelhoff
Copy link
Member

sappelhoff commented Mar 25, 2021

I also find several issues in the "build pdf" step regarding images and characters not being available in a font. Worth investigating later.

These warnings look legitimate, especially in reference to the image files:

[WARNING] Duplicate link reference '[deprecated]' at line 2394 column 1
[WARNING] Duplicate link reference '[string]' at line 2396 column 1
[WARNING] Duplicate link reference '[strings]' at line 2398 column 1
[WARNING] Duplicate link reference '[uri]' at line 2414 column 1
[WARNING] Duplicate link reference '[strings]' at line 4302 column 1
[WARNING] Duplicate link reference '[string]' at line 4461 column 1
[WARNING] Duplicate link reference '[derived-dataset-description]' at line 4552 column 1
[WARNING] Could not fetch resource '../04-modality-specific-files/images/asl_pcasl_sequence.png': replacing image with description
[WARNING] Could not fetch resource '../04-modality-specific-files/images/asl_pcasl_labeling_pulses.png': replacing image with description
[WARNING] Could not fetch resource '../04-modality-specific-files/images/asl_pasl_boluscutoff_false.png': replacing image with description
[WARNING] Could not fetch resource '../04-modality-specific-files/images/asl_pasl_boluscutoff_true_quipssII.png': replacing image with description
[WARNING] Could not fetch resource '../04-modality-specific-files/images/asl_pasl_boluscutoff_true_q2tips.png': replacing image with description
[WARNING] Could not fetch resource '../04-modality-specific-files/images/asl_flowchart.png': replacing image with description
[WARNING] Missing character: There is no └ (U+2514) in font [lmmono10-regular]:!
[WARNING] Missing character: There is no ─ (U+2500) in font [lmmono10-regular]:!
[WARNING] Missing character: There is no ─ (U+2500) in font [lmmono10-regular]:!
[WARNING] Missing character: There is no └ (U+2514) in font [lmmono10-regular]:!
[WARNING] Missing character: There is no ─ (U+2500) in font [lmmono10-regular]:!
[WARNING] Missing character: There is no ─ (U+2500) in font [lmmono10-regular]:!
[WARNING] Missing character: There is no ├ (U+251C) in font [lmmono10-regular]:!

Originally posted by @sappelhoff in #759 (comment)

there is also another known warning :

[WARNING] Deprecated: markdown_github. Use gfm instead.

That's something we do deliberately, because gfm breaks our tables, if I remember correctly.

EDIT: The missing font characters for "pipe symbols" has been fixed in #837

@sappelhoff sappelhoff changed the title [infra] PDF build on CI raises warnings: font and images (ASL) impacted [INFRA] PDF build on CI raises warnings: font and images (ASL) impacted Mar 25, 2021
@sappelhoff
Copy link
Member Author

sappelhoff commented Mar 26, 2021

the issue on not-found images is due to the fact that pandoc searches for relative paths relative to the working directory.

And currently, the working directory (where pandoc is invoked) is in ./pdf_build_src/src_copy/src.

(src_copy/src is temporary, the build output will be in ./pdf_build_src)

I'll fix this in #767

@sappelhoff
Copy link
Member Author

The warnings about missing characters can be fixed by setting a mono font that supports unicode in the header setup. Something like this \setmonofont{DejaVu Sans Mono} added below these lines:

\usepackage{fontspec}
\setmainfont{Symbola}

However, that results in the following (screenshot):

image

I guess somebody needs to try a couple of fonts and find out what works and what doesn't.

The issue of missing characters isn't too bad, because even when they are missing, the rendering looks good:

image

@sappelhoff sappelhoff changed the title [INFRA] PDF build on CI raises warnings: font and images (ASL) impacted [INFRA] PDF build on CI raises warnings: font impacted, duplcate links Mar 26, 2021
@sappelhoff sappelhoff changed the title [INFRA] PDF build on CI raises warnings: font impacted, duplcate links [INFRA] PDF build on CI raises warnings: font impacted, duplicate links Mar 26, 2021
@sappelhoff
Copy link
Member Author

Finally, the "duplicate links" issue can probably be fixed reasonably well in

"""Process the markdown files.

... but it's also not too bad, because it does not affect the rendering and/or usability.

@sappelhoff sappelhoff added the formatting Aesthetics and formatting of the spec label Mar 26, 2021
@sappelhoff sappelhoff changed the title [INFRA] PDF build on CI raises warnings: font impacted, duplicate links [INFRA] PDF build on CI raises warnings: duplicate links Aug 24, 2021
@sappelhoff
Copy link
Member Author

All issues have been picked off by other PRs. The only issue that remains is kind of a duplicate of #596 - so I am closing this one now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formatting Aesthetics and formatting of the spec
Projects
None yet
Development

No branches or pull requests

1 participant