Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should spell out prevention for case-insensitive collisions #857

Closed
yarikoptic opened this issue Aug 20, 2021 · 1 comment
Closed

Should spell out prevention for case-insensitive collisions #857

yarikoptic opened this issue Aug 20, 2021 · 1 comment

Comments

@yarikoptic
Copy link
Collaborator

yarikoptic commented Aug 20, 2021

problem in detail.

the encounter life cycle:

and well -- upon my search in bids-specification or bids-validator I found no relevant hits. It seems that BIDS nohow instructs to avoid such collisions -- in https://bids-specification.readthedocs.io/en/stable/02-common-principles.html we just say " - an alphanumeric value, possibly prefixed with arbitrary number of 0s for consistent indentation, for example, it is rest in task-rest following task- specification."

I think we should

  • extend label description that the value MUST be unique and present in a single casing (e.g. there should also be no sub-S1 and sub-s1 in the same dataset ).
  • bids-validator should verify that there is no such collisions (e.g. crude test is len(set(paths)) == len(set([p.lower() for p in paths]))) and issue ERROR
@sappelhoff
Copy link
Member

Thanks for bringing this up, I wonder why we didn't run into problems with this much sooner. My gut feeling tells me that your proposed (breaking) change is good and should go into BIDS 1.x as a "bugfix".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants