-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MISC] Rewrite and update html build instructions #1032
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see we had the same idea about the main changes to make without talking about it. 🤗
Also added basic snippet to clone and set up the environments because I tend to get annoyed by tutos or set up instructions that say, "to do step 1, read this other 30 000 words tuto".
Co-authored-by: Remi Gau <remi_gau@hotmail.com>
Co-authored-by: Remi Gau <remi_gau@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go
Co-authored-by: Mateusz Pawlik <mateusz.pawlik@plus.ac.at>
I think this issue fits here. When I modified |
That's a bit weird indeed - I clarified with Taylor (who is the expert on everything schema related) and he couldn't replicate your issue. Furthermore, the CI pretty much runs the same code as you, and there the changes also appeared in the build output. bids-specification/.circleci/config.yml Lines 6 to 24 in 88a9730
Perhaps that's some idiosyncratic issue on your system/setup OR you maybe did a mistake somewhere? Anyhow, if you have a concrete suggestion what to improve, please let me know :-) |
I tried it again carefully from scratch.
Removing My versions of the Python packages:
I couldn't find any related issue in https://github.com/fralau/mkdocs_macros_plugin/ |
I think I've found the problem. The I changed the content of |
You can also use |
Thanks @mateuszpawlik for investigating, that makes sense ... I hadn't thought of that. I took Chris' solution and added it as a commit to the contributor instructions. |
Failures are due to Jinja2 3.1 release 30 minutes ago:
EDIT: see also mkdocs/mkdocs#2794 |
closes #1030
This is changing the order of instructions:
that's important because we have the schema package, which is local -- so navigating to the local dir of the spec ensures success.
Furthermore I recommend using an isolated python environment -- that way we can do without the "special instructions" in case somebody doesn't want numpy (in an isolated env it doesn't really matter if they have numpy or not).