-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] IntendedFor in (i)EEG is dataset relative #1093
[FIX] IntendedFor in (i)EEG is dataset relative #1093
Conversation
sappelhoff
commented
Apr 25, 2022
•
edited
Loading
edited
- closes Incoherent IntendedFor definitions #1076
- closes Specification of AssociatedEmptyRoom #790
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1093 +/- ##
==========================================
+ Coverage 70.75% 71.71% +0.96%
==========================================
Files 9 9
Lines 937 937
==========================================
+ Hits 663 672 +9
+ Misses 274 265 -9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tsalo is the way I deal with the schema here fine?
It looks good to me. I would have recommended |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!