Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Clarify that dataset_description.Genetics object is required for genetics data #1442

Merged
merged 4 commits into from
Mar 24, 2023

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented Mar 16, 2023

…r genetics data

also clarify that Genetics.Dataset is required if Genetics is supplied
@sappelhoff sappelhoff requested a review from CPernet March 20, 2023 09:55
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.12 ⚠️

Comparison is base (8f21b45) 88.01% compared to head (208daf4) 87.90%.

❗ Current head 208daf4 differs from pull request most recent head 805a778. Consider uploading reports for the commit 805a778 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1442      +/-   ##
==========================================
- Coverage   88.01%   87.90%   -0.12%     
==========================================
  Files          14       14              
  Lines        1268     1273       +5     
==========================================
+ Hits         1116     1119       +3     
- Misses        152      154       +2     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sappelhoff sappelhoff added this to the 1.9.0 milestone Mar 20, 2023
@effigies
Copy link
Collaborator

Woops. Double approved. Must be really good.

@sappelhoff
Copy link
Member Author

Woops. Double approved. Must be really good.

you should have double-approved #1444 because that's almost literally your suggestion ;-)

(actually, I should have acknowledged you in the commit there)

@sappelhoff sappelhoff merged commit 2f94687 into bids-standard:master Mar 24, 2023
@sappelhoff sappelhoff deleted the genetics branch March 24, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Genetics metadata field is OPTIONAL in specification, but REQUIRED in validator
3 participants