-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Clarify that dataset_description.Genetics object is required for genetics data #1442
Conversation
…r genetics data also clarify that Genetics.Dataset is required if Genetics is supplied
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1442 +/- ##
==========================================
- Coverage 88.01% 87.90% -0.12%
==========================================
Files 14 14
Lines 1268 1273 +5
==========================================
+ Hits 1116 1119 +3
- Misses 152 154 +2 see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Woops. Double approved. Must be really good. |
you should have double-approved #1444 because that's almost literally your suggestion ;-) (actually, I should have acknowledged you in the commit there) |
also clarify that Genetics.Dataset is required if Genetics is supplied.
closes #1395