Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCHEMACODE: Add data loader class #1506

Merged
merged 3 commits into from
Jun 25, 2023

Conversation

effigies
Copy link
Collaborator

While working on documentation, I noticed we have data modules with nothing in them. Been playing around with ideas to make resource fetching more streamlined, and created a Loader() class that streamlines loading and shows the available data when its docstring is rendered.

@effigies effigies added schema-code Updates or changes to the code used to parse, filter, and render the schema. exclude-from-changelog This item will not feature in the automatically generated changelog labels May 26, 2023
@effigies
Copy link
Collaborator Author

Render:

@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.32 🎉

Comparison is base (bda5ffe) 87.68% compared to head (a0bc77a) 88.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1506      +/-   ##
==========================================
+ Coverage   87.68%   88.00%   +0.32%     
==========================================
  Files          14       16       +2     
  Lines        1291     1326      +35     
==========================================
+ Hits         1132     1167      +35     
  Misses        159      159              
Impacted Files Coverage Δ
tools/schemacode/bidsschematools/data/__init__.py 100.00% <100.00%> (ø)
.../schemacode/bidsschematools/tests/data/__init__.py 100.00% <100.00%> (ø)
tools/schemacode/bidsschematools/utils.py 62.50% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@effigies effigies merged commit 8ef9920 into bids-standard:master Jun 25, 2023
17 checks passed
@effigies effigies deleted the tools/data_loader branch June 25, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog schema-code Updates or changes to the code used to parse, filter, and render the schema.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant