[ENH] Allow for "echo" entity to be used with T1w and other nonparametric anatomical suffixes #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…metric) sequences Closes bids-standard#654 bids-standard#654 provides more of discussion with a number of people bringing up the use cases which keep coming about. As EchoTime is a recommended sidecar file metadata field for any file of 'mri' modality, I decided that it would only be logical for at least existing use cases (T1w) and possibly other cases (to not overspecify T1w) to simply allow for "echo" entity to be used if so necessary to distignuish two files while they do remain of that weighting (e.g. T1w) given the EchoTime values.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1570 +/- ##
=======================================
Coverage 87.83% 87.83%
=======================================
Files 16 16
Lines 1356 1356
=======================================
Hits 1191 1191
Misses 165 165 ☔ View full report in Codecov by Sentry. |
effigies
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Based on @yarikoptic and @neurolabusc's latest comments[0][1] on #654, I think this is a reasonable change.
effigies
changed the title
|
The aye's have it. |
|
I'm a little late chiming in, but I also support this change. If there is confusion what the weighting (t1, t2, pd) means when dealing with multiple echos, I think we can say the weighting refers to the first (and highest SNR) echo which, to my knowledge, is the common convention. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #654
#654 provides more of discussion with a number of people bringing up the use cases which keep coming about.
As EchoTime is a recommended sidecar file metadata field for any file of 'mri' modality, I decided that it would only be logical for at least existing use cases (T1w) and possibly other cases (to not overspecify T1w) to simply allow for "echo" entity to be used if so necessary to distignuish two files while they do remain of that weighting (e.g. T1w) given the EchoTime values.