[FIX] Hierarchical Event Descriptors (HED) page update #1623
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1623 +/- ##
=======================================
Coverage 87.83% 87.83%
=======================================
Files 16 16
Lines 1356 1356
=======================================
Hits 1191 1191
Misses 165 165 ☔ View full report in Codecov by Sentry. |
src/appendices/hed.md
Outdated
| `events.tsv` file with onset `1.2` (the first row) is: | ||
|
|
||
| ```Text | ||
| Duration/0.6 s, Sensory-event, Visual-presentation, (Square, Blue), | ||
| (Delay/1.435 ms, Agent-action, (Experiment-participant, (Press, Mouse-button))), | ||
| (Duration/0.6 s, Sensory-event, Visual-presentation, |
There was a problem hiding this comment.
This is not correct without the curly brace notation, which is not yet supported by the HED javascript validator used in bids. Until that all goes through, the annotation for the presentation cannot be enclosed in parentheses:
Duration/0.6 s, Sensory-event, Visual-presentation,
((Square, Red), (Computer-screen, Center-of)),
@effigies can you correct. Tal will not be available for a while.
src/appendices/hed.md
Outdated
|
|
||
| ### Using HED library schemas | ||
|
|
||
| HED also allows you to use one or more specialized vocabularies along with or instead of | ||
| HED also allows you to use one or more specialized vocabulary along with or instead of |
There was a problem hiding this comment.
I think this should be vocabularies not vocabulary because of the "more".
src/appendices/hed.md
Outdated
| @@ -206,22 +224,24 @@ SCORE library for clinical neurological annotation located at | |||
| "HEDVersion": ["8.1.0", "sc:score_1.0.0"] | |||
| } | |||
| ``` | |||
| The `sc:` is a user-chosen prefixes used to distinguish the sources | |||
| The `sc:` is a user-chosen prefix used to distinguish the sources | |||
There was a problem hiding this comment.
The sc: is a user-chosen prefix used to distinguish the source schemas
|
@VisLab Updated with your suggestions (or minor variations thereon). Please LMK what you think. |
Squashed #1592 without some merge noise that reverted unrelated changes.
@tpatpa @VisLab Can you please review to make sure I didn't lose any of the originally planned changes?
Closes #1592.