Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Move rawdata/ into sourcedata/raw in alternative structure example, clarify on naming of datasets themselves #1741

Merged
merged 10 commits into from
Apr 25, 2024

Commits on Mar 21, 2024

  1. RF: move rawdata/ to sourcedata/raw in an example + make overall …

    …dataset to be BIDS dataset
    
    This is my take on an extended discussion about ambiguity of
    `rawdata/` example:
    https://github.com/bids-standard/bids-specification/pull/1734/files#r1534475631
    yarikoptic committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    16d57d3 View commit details
    Browse the repository at this point in the history
  2. Minor rewording in description of sourcedata/ content

    Prior one bundled naming aspect under the same MUST. I separated into
    separate sentences, added explicit statement that BIDS does not
    prescribe a particular naming scheme for source data. And added
    explicit RECOMMENDED on the example how to organize/name files there.
    yarikoptic committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    a6107e8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    758c3f6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2f018e5 View commit details
    Browse the repository at this point in the history
  5. [DATALAD RUNCMD] Replace use of rawdata in tests with explicit 'nonco…

    …mpliant'
    
    === Do not change lines below ===
    {
     "chain": [],
     "cmd": "sed -i -e s,rawdata,noncompliant,g tools/schemacode/bidsschematools/validator.py tools/schemacode/bidsschematools/tests/test_validator.py tools/schemacode/bidsschematools/tests/data/expected_bids_validator_xs_write.log",
     "exit": 0,
     "extra_inputs": [],
     "inputs": [],
     "outputs": [],
     "pwd": "."
    }
    ^^^ Do not change lines above ^^^
    yarikoptic committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    7cae13d View commit details
    Browse the repository at this point in the history
  6. Do not use e.g.

    yarikoptic committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    6ac34ea View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. Configuration menu
    Copy the full SHA
    526374e View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Configuration menu
    Copy the full SHA
    a3c12f8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5974b0e View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Make into a single sentence

    Co-authored-by: Chris Markiewicz <effigies@gmail.com>
    yarikoptic and effigies committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    1c029c6 View commit details
    Browse the repository at this point in the history