[ENH] Generalize Units definition to apply to any variable, including TSV columns #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…field in sidecar)
yarikoptic
requested review from
effigies and
tsalo
and removed request for
erdalkaraca and
tsalo
|
This was written for qMRI, I think, where the units might be defined for the entire data array. I do think variable is fine, but note that it now reads this way for an image:
I think it's probably clear enough. |
effigies
approved these changes
Jun 6, 2024
effigies
changed the title
tsalo
approved these changes
Jun 6, 2024
tsalo
changed the title
|
well, we also could just make it "Measurement unit." I am fine either way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.