From 184d8c0494a64ddf5183deaeed3e54b47eb4fc12 Mon Sep 17 00:00:00 2001 From: Ross Blair Date: Wed, 7 Aug 2024 17:12:25 -0500 Subject: [PATCH 1/3] add non behavioral datatype assertion for warning about missing events.tsv --- src/schema/rules/checks/events.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/src/schema/rules/checks/events.yaml b/src/schema/rules/checks/events.yaml index a5fa9ac5fd..f1a165bc87 100644 --- a/src/schema/rules/checks/events.yaml +++ b/src/schema/rules/checks/events.yaml @@ -10,6 +10,7 @@ EventsMissing: level: warning # could be an error with the proper selectors, I think selectors: - dataset.dataset_description.DatasetType == "raw" + - datatype != "beh" - '"task" in entities' - '!match(entities.task, "rest")' - suffix != "events" From 48e3450d92b4dd169c949a7a5acc05156f944827 Mon Sep 17 00:00:00 2001 From: Ross Blair Date: Wed, 7 Aug 2024 17:17:49 -0500 Subject: [PATCH 2/3] should not apply to behaviorally suffixed files either. --- src/schema/rules/checks/events.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/schema/rules/checks/events.yaml b/src/schema/rules/checks/events.yaml index f1a165bc87..c30057c8b2 100644 --- a/src/schema/rules/checks/events.yaml +++ b/src/schema/rules/checks/events.yaml @@ -13,7 +13,7 @@ EventsMissing: - datatype != "beh" - '"task" in entities' - '!match(entities.task, "rest")' - - suffix != "events" + - '!(suffix in ["events", "beh"])' - extension != ".json" checks: - '"events" in associations' From bc481cd80a9197153365c27df1fc1dcbdd40005a Mon Sep 17 00:00:00 2001 From: Ross Blair Date: Mon, 12 Aug 2024 13:23:29 -0500 Subject: [PATCH 3/3] Update src/schema/rules/checks/events.yaml Co-authored-by: Chris Markiewicz --- src/schema/rules/checks/events.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/schema/rules/checks/events.yaml b/src/schema/rules/checks/events.yaml index c30057c8b2..4c4e143afd 100644 --- a/src/schema/rules/checks/events.yaml +++ b/src/schema/rules/checks/events.yaml @@ -13,7 +13,7 @@ EventsMissing: - datatype != "beh" - '"task" in entities' - '!match(entities.task, "rest")' - - '!(suffix in ["events", "beh"])' + - '!intersects([suffix], ["events", "beh"])' - extension != ".json" checks: - '"events" in associations'