Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schema): Move coordsystem.json rules out of rules.sidecars #1892

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

effigies
Copy link
Collaborator

We were mixing up JSON and sidecar rules, but conceptually, sidecar metadata belongs to the data file, not the JSON file itself. coordsystem.json is its own JSON file, and needs to be validated as its own thing, in the same way dataset_description.json is.

The upshot is that selectors should use json.<whatever> instead of sidecar.<whatever> to make conditional requirements, and it will be easiest to keep these entirely separate in the schema.

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.10%. Comparing base (0de4c9c) to head (574f7f6).
Report is 171 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1892      +/-   ##
==========================================
- Coverage   88.22%   88.10%   -0.12%     
==========================================
  Files          16       16              
  Lines        1393     1396       +3     
==========================================
+ Hits         1229     1230       +1     
- Misses        164      166       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit ef4a939 into bids-standard:master Aug 20, 2024
26 of 27 checks passed
@effigies effigies deleted the fix/coordsystem_rules branch August 20, 2024 15:27
@effigies effigies added schema Issues related to the YAML schema representation of the specification. Patch version release. exclude-from-changelog This item will not feature in the automatically generated changelog labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog schema Issues related to the YAML schema representation of the specification. Patch version release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants