-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REL: v1.2.2 #405
REL: v1.2.2 #405
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me.
src/CHANGES.md
Outdated
@@ -1,6 +1,6 @@ | |||
Changelog | |||
|
|||
## [Unreleased](https://github.com/bids-standard/bids-specification/tree/HEAD) | |||
## [v1.2.2](https://bids-specification.readthedocs.io/en/v1.2.2/) (2020-02-03) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the links for all of the other releases?
Also, can we remove the REL
changelog entries from the top of each release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed the RTD links - I am hesitant to link to the previous pre-RTD until #392 has been resolved so we do not have broken links in previous versions
this can be released for stable but will appear back on latest because of how the changelog is generated (for each merged PR), a separate issue could address enhancing the changelog generation
to keep track of release protocol additions I've started a ticket (#406)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't suggest removing L48 as well:
- REL: v1.2.1 [#291](https://github.com/bids-standard/bids-specification/pull/291) ([franklin-feingold](https://github.com/franklin-feingold))
src/CHANGES.md
Outdated
@@ -99,7 +99,7 @@ Changelog | |||
- \[FIX] Specify marker file names for KIT data (MEG) [#62](https://github.com/bids-standard/bids-specification/pull/62) ([monkeyman192](https://github.com/monkeyman192)) | |||
- \[FIX] Remove father-level for meg filetypes other than BTi/4D data [#19](https://github.com/bids-standard/bids-specification/pull/19) ([teonbrooks](https://github.com/teonbrooks)) | |||
|
|||
## [v1.2.0](https://github.com/bids-standard/bids-specification/tree/v1.2.0) (2019-03-04) | |||
## [v1.2.0](https://bids-specification.readthedocs.io/en/v1.2.0/) (2019-03-04) | |||
|
|||
- REL: v1.2.0 [#161](https://github.com/bids-standard/bids-specification/pull/161) ([chrisgorgo](https://github.com/chrisgorgo)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- REL: v1.2.0 [#161](https://github.com/bids-standard/bids-specification/pull/161) ([chrisgorgo](https://github.com/chrisgorgo)) |
src/CHANGES.md
Outdated
@@ -117,7 +117,7 @@ Changelog | |||
- Adding formal decision-making rules [#104](https://github.com/bids-standard/bids-specification/pull/104) ([chrisgorgo](https://github.com/chrisgorgo)) | |||
- \[MRG] number of small corrections to the specification [#98](https://github.com/bids-standard/bids-specification/pull/98) ([robertoostenveld](https://github.com/robertoostenveld)) | |||
|
|||
## [v1.1.2](https://github.com/bids-standard/bids-specification/tree/v1.1.2) (2019-01-10) | |||
## [v1.1.2](https://bids-specification.readthedocs.io/en/v1.1.2/) (2019-01-10) | |||
|
|||
- REL: v.1.1.2 [#121](https://github.com/bids-standard/bids-specification/pull/121) ([chrisgorgo](https://github.com/chrisgorgo)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- REL: v.1.1.2 [#121](https://github.com/bids-standard/bids-specification/pull/121) ([chrisgorgo](https://github.com/chrisgorgo)) |
src/CHANGES.md
Outdated
@@ -39,7 +39,7 @@ Changelog | |||
- \[ENH] Added discontinuous datatype for EEG and iEEG [#286](https://github.com/bids-standard/bids-specification/pull/286) ([wouterpotters](https://github.com/wouterpotters)) | |||
- \[FIX] Clarify paragraph about custom data types [#264](https://github.com/bids-standard/bids-specification/pull/264) ([effigies](https://github.com/effigies)) | |||
|
|||
## [v1.2.1](https://github.com/bids-standard/bids-specification/tree/v1.2.1) (2019-08-14) | |||
## [v1.2.1](https://bids-specification.readthedocs.io/en/v1.2.1/) (2019-08-14) | |||
|
|||
- Sync rel/1.2.1 to master [#302](https://github.com/bids-standard/bids-specification/pull/302) ([franklin-feingold](https://github.com/franklin-feingold)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Sync rel/1.2.1 to master [#302](https://github.com/bids-standard/bids-specification/pull/302) ([franklin-feingold](https://github.com/franklin-feingold)) |
releasing specification version 1.2.2 following our release protocol