[INFRA] Update release protocol #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update 10-21
update 1/24
rel update
update 3/10
sappelhoff
previously approved these changes
Mar 11, 2020
There was a problem hiding this comment.
Looks good to me @franklin-feingold, thanks for updating it.
effigies
previously approved these changes
Mar 11, 2020
Release_Protocol.md
Outdated
| @@ -35,7 +35,7 @@ $ git fetch upstream | |||
| $ git checkout -b rel/1.2.0 upstream/master | |||
| ``` | |||
|
|
|||
| ### 2. Update the version and the contributors list | |||
| ### 2. Update the version, contributors list, linking of previous versions, and the Changelog | |||
There was a problem hiding this comment.
Nit-pick: "linking" here and "sharing" below are a different verb tense than "Update", "Commit", "Clean", Set", etc...
There was a problem hiding this comment.
updated to remove "linking"
franklin-feingold
dismissed stale reviews from effigies and sappelhoff
via
44e4a53
sappelhoff
approved these changes
Mar 12, 2020
|
Thanks @franklin-feingold, can you please update your checklist in #406 to reflect what's still needed to close #406 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a large part of #406
In this PR I have added to the release protocol:
Things left to do: