[FIX] Clarify snake_case+CamelCase in TSV+JSON #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertoostenveld
previously approved these changes
Apr 1, 2020
|
Thank you for clarifying here |
|
@dorahermes I pushed a new commit, I think it's even more clear now. |
sappelhoff
requested review from
robertoostenveld,
dorahermes,
effigies and
franklin-feingold
yarikoptic
reviewed
Apr 6, 2020
src/04-modality-specific-files/01-magnetic-resonance-imaging-data.md
Outdated
Show resolved
Hide resolved
yarikoptic
requested changes
Apr 6, 2020
|
Thanks @yarikoptic linkchecker passes now. |
franklin-feingold
previously approved these changes
Apr 6, 2020
GREAT! Since I started to worry if it all of a sudden became more buggy than useful ;) apparently it is still of benefit! ;) |
robertoostenveld
approved these changes
Apr 9, 2020
effigies
approved these changes
Apr 9, 2020
Merged
bids-maintenance
added a commit
that referenced
this pull request
Apr 9, 2020
sappelhoff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: bids-standard/bids-starter-kit#130 (comment)
I had the same impression as @robertoostenveld and scanned the spec for any part mentioning that convention that we follow.
I did not find it, so I add it with this PR, RECOMMENDING the use of this convention.