[INFRA] make circle artifact link a GH action, point to pdf #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinging @yarikoptic and @effigies who have some experience with this. I just don't want to merge this without prior discussion / approval. |
|
Seems fine. |
|
Okay, I removed pipfile and pipfile.lock and made the build_docs job in circleci leaner ... but couldn't get rid of it because it's needed for the linkchecker job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #484
Some changes, because the HTML preview for PRs is now provided by Readthedocs.
Now the big question is whether or not to remove the CircleCI build of the HTML version. Removing it would mean:
build_docsjobThe readthedocs build apparently only uses
requirements.txtand the "RTD defaults" which they install for every build anyhow. (interestingly,edit: this pkg IS being installed, because it's a dependency of "mkdocs-material" )pymdown-extensionsare not being installed by RTD, but are a requirement for the circleci build 🤷I am not sure whether to remove or not. It seems fair to get rid of unneeded things ... especially if they are NOT an exact mirror of the Readthedocs build environment and thus cannot be of help for debugging.
What are your opinions?