Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] fix links, make json object links consistent, fix pandoc rendering #587

Merged
merged 8 commits into from
Sep 5, 2020

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented Aug 31, 2020

closes #565

with this PR:

@sappelhoff sappelhoff marked this pull request as ready for review August 31, 2020 07:51
Comment on lines +138 to +140
Storing actual source files with the data is preferred over links to
external source repositories to maximize long term preservation,
which would suffer if an external repository would not be available anymore.
Copy link
Member Author

@sappelhoff sappelhoff Aug 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These sentences come from the code section. The code section now contains a link to this section instead.

see: #587 (comment)

Comment on lines -377 to -379
<sup>1</sup>Storing actual source files with the data is preferred over links to
external source repositories to maximize long term preservation (which would
suffer if an external repository would not be available anymore).
Copy link
Member Author

@sappelhoff sappelhoff Aug 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these lines are now in the sourcedata section: #587 (comment)

and as you can see above, the code section now links to that section.

Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>
Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Small typos.

src/03-modality-agnostic-files.md Outdated Show resolved Hide resolved
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDF rendering: "link definition" comment sections are also rendered instead of being skipped
3 participants