-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] clarify definition of events in common principles #595
Conversation
Friendly ping @sappelhoff, what do you think about #564 (comment) ? |
@hoechenberger can you review this PR, given that discussion in #564 has converged upon accepting this extended definition provided by @VisLab ? |
"noise and vibrations due to construction works" might be better as "noise and vibrations due to construction work" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nitpick but otherwise LGTM
Co-authored-by: VisLab <1189050+VisLab@users.noreply.github.com>
Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com> Co-authored-by: VisLab <1189050+VisLab@users.noreply.github.com>
Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>
closes #564
cc @VisLab I entered your suggestion.
We can now discuss it and then get it merged.
Feedback welcome.