[ENH] Clarify run indexing information for MRI acquisitions #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsalo
approved these changes
Feb 2, 2021
|
Are the CI failures expected? Do they need to be addressed separately? |
|
No that's weird. I'm guessing it's the result of #610 interacting with #714. I will try to fix. EDIT: I've figured it out. In #610 we switched to using the entity names, rather than keys, in the datatype YAML files, while in #714 we changed those names for a couple of entities. I'll open a PR to fix. |
…ata.md Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
sappelhoff
force-pushed
the
enh/clarify_run
branch
from
a197fd9
to
b9d9b7b
Compare
sappelhoff
approved these changes
Feb 3, 2021
|
@dlevitas Does this work for you? |
|
This looks good to me! |
|
Great! If you haven't already, could you go ahead and add yourself to the recent contributors? This will make sure we credit you on the next release for your contribution. |
|
Thanks everybody! |
sappelhoff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #694.