Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Typos discovered by codespell #784

Merged
merged 2 commits into from
Apr 22, 2021

Conversation

yarikoptic
Copy link
Collaborator

I did not go wild and automate it but codespell is nice and someone might. There would need to be some exclusions given all abbreviations etc, but here is what it would say now after these fixes and excluding embedded JS

$> codespell src | grep -v '\.js'
src/01-introduction.md:119: TE ==> THE, BE, WE
src/04-modality-specific-files/01-magnetic-resonance-imaging-data.md:97: TE ==> THE, BE, WE
src/04-modality-specific-files/images/PET_scan_overview.svg:1: bre ==> be, brie
src/04-modality-specific-files/images/PET_scan_overview.svg:1: ba ==> by, be
src/04-modality-specific-files/images/PET_scan_overview.svg:1: ba ==> by, be
src/99-appendices/08-coordinate-systems.md:92: ALS ==> ALSO
src/99-appendices/08-coordinate-systems.md:94: ALS ==> ALSO
src/99-appendices/08-coordinate-systems.md:95: ALS ==> ALSO

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "find src -iname '*.md' | xargs sed -e 's,sytem,system,g' -e 's,auxilliary,auxiliary,g' -e 's,compliancy,compliance,g' -e 's,Plase,Please,g' -e 's,targetted,targeted,g' -e 's,Descripton,Description,g' -e 's,Perferred,Preferred,g' -e 's,entitites,entities,g' -e 's,algoritm,algorithm,g' -e 's,applicaiton,application,g' -e 's,avaiable,available,g' -e 's,neccesary,necessary,g' -e 's,refered,referred,g' -i",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All typos look good. I'm a little surprised that the linter didn't complain about misaligned tables. Did you fix those and it just doesn't look like it?

@effigies effigies changed the title [DATALAD RUNCMD] Fix some typos detected by codespell src FIX: Typos discovered by codespell Apr 21, 2021
@yarikoptic
Copy link
Collaborator Author

hm, no - I didn't do anything extra beyond that sed command

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typos look good thanks.

I'd be in favor of (before merging) pushing a commit that obviously violates a table to see if CIs are triggered by that ...

we can then revert the commit and know more about whether or not we need to fix CIs.

@effigies
Copy link
Collaborator

@sappelhoff I manually fixed the table alignment. I would rather get this in, release 1.6.0, and check on the CI after. I don't want a potential rabbit hole blocking obviously good fixes, and I don't want to release with typos we know are there.

WDYT?

@sappelhoff
Copy link
Member

yes, makes sense!

@effigies effigies merged commit 0900f12 into bids-standard:master Apr 22, 2021
@effigies effigies added this to the 1.6.0 milestone Apr 29, 2021
@sappelhoff sappelhoff changed the title FIX: Typos discovered by codespell [FIX] Typos discovered by codespell May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants