[MISC] add "forward slash" requirement for paths to common principles #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarikoptic
reviewed
Sep 2, 2021
src/02-common-principles.md
Outdated
|
|
||
| Throughout BIDS all such paths MUST be specified using the slash character (`/`), | ||
| regardless of the operating system that a particular dataset is curated on | ||
| or used on. |
There was a problem hiding this comment.
I guess if such section is added, it should specify that paths must not be absolute local paths, thus must not start with /.
Didn't analyze yet, but also something might need to be said then what they are relative to, or that what they are relative to would depend on where used.
There was a problem hiding this comment.
I added some language for that, ... in the meantime, #820 was replaced with #918 - so we should either:
- merge this before [ENH] Add BIDS URIs and deprecate relative paths, RawSources and (possibly unused) BasedOn #918 and then potentially adjust the added text here in [ENH] Add BIDS URIs and deprecate relative paths, RawSources and (possibly unused) BasedOn #918, OR
- wait until [ENH] Add BIDS URIs and deprecate relative paths, RawSources and (possibly unused) BasedOn #918 is merged, then adjust this one and merge it.
sappelhoff
force-pushed
the
common_principles/forward-slash-paths
branch
from
a8ed08b
to
63f47d1
Compare
effigies
approved these changes
Jan 28, 2022
Lestropie
added a commit
to Lestropie/bids-specification
that referenced
this pull request
Apr 29, 2022
Resolves bids-standard#947 against: - bids-standard#962 (21b7725) - bids-standard#1044 (d9eeb6d) - bids-standard#867 (5fe26e1) - bids-standard#998 (e47283a) Conflicts: src/02-common-principles.md src/schema/README.md src/schema/objects/entities.yaml src/schema/objects/metadata.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #849
closes bids-standard/bids-validator#1408