[FIX] Clarify shifting dates RECOMMENDED, add example EDF #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sappelhoff
requested review from
adam2392,
hoechenberger and
robertoostenveld
hoechenberger
approved these changes
Oct 26, 2021
effigies
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #698
While browsing #698, I realized that in the spec we are slightly inconsistent: In the modality agnostic files section, we RECOMMEND that shifted dates are in the year 1925 or earlier, and emphasize that shifting is RECOMMENDED, not required.
Yet in the Common Principles section, we write:
In this PR I propose to rephrase what we have in Common Principles and clarify that shifting dates is RECOMMENDED (not required) and preferably done to or prior to 1925 (but again, not required).
I think that makes the spec both more consistent, and avoids nonsensical situations were we have a data format like EDF which cannot technically contain recording dates prior to 1985, but which BIDS REQUIRES to have a date prior to 1925.