[ENH] Update B0Field metadata to accommodate single-blip fieldmaps #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sappelhoff
reviewed
Jan 15, 2022
|
Because these are strings, not paths. |
oesteban
approved these changes
Jan 18, 2022
|
Thanks for this. |
effigies
force-pushed
the
enh/b0field_fixups
branch
from
6728d24
to
92559f8
Compare
Codecov Report
@@ Coverage Diff @@
## master #968 +/- ##
=======================================
Coverage 36.16% 36.16%
=======================================
Files 8 8
Lines 788 788
=======================================
Hits 285 285
Misses 503 503 Continue to review full report at Codecov.
|
sappelhoff
approved these changes
Feb 1, 2022
sappelhoff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #622. We realized that as currently worded, there are unresolvable ambiguities for pepolar schemes. Consider the case where you have two BOLD series and one reverse-PE EPI fieldmap. The inputs to estimate the fieldmap could be one or both BOLD files (along with the reverse-PE EPI), and the estimated fieldmap could then apply to one or both.
This allows files to be listed as part of multiple identifiers, and for a BOLD file to be part of an
B0FieldIdentifierAND have aB0FieldSource.