-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
false positive errors on a beh.json file #1364
Comments
without having cross-checked this:
So I think your example should definitely pass. +1 for being lenient (your 1st suggestion) I think a check for onset+duration in beh.tsv and a contingent recommendation (warning) that beh.tsv might actually be an events.tsv sounds like a potential (low priority) enhancement 🤔 |
Actually how about this change: we recommend in the spec that |
Yeah 👍 ... as of now, beh.json is not even explicitly mentioned: https://bids-specification.readthedocs.io/en/latest/04-modality-specific-files/07-behavioral-experiments.html making a comparison that "similar to events tsv+json, the beh tsv should have a (similar) json file" ... and that that's where all the metadata (cited at the bottom of the page) can/should be reported |
Some colleagues tries to use a
beh
folder to organize their data and has been getting some errors on the json content that look like false positive.I have been able to reproduce the error here:
Here I copied an
events.tsv
and its side car and renamed it intobeh.tsv
Apparently the specifications says nothing of how the content of
beh.json
should be organized.So it looks like the validator is complaining as soon as one puts anything in the json file (an empty
{}
is ok though).Also note that the validator is not picking up that the
beh.tsv
has bothonset
andduration
and should then probably be anevents.tsv
- though see this case in thebids-example
.Suggestions:
beh.json
files should be organizedbeh.json
files should have the same structure asevents.json
(will require an update of the spec)The text was updated successfully, but these errors were encountered: