-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional column names in channels.tsv #1410
Comments
Hi Jonathan, the link from the spec that you posted is about EEG data. However, from the screenshots you posted it looks like you have iEEG data. For this kind of data, low and high cutoff are indeed required. See here: |
Dear Stefan Thank you very much for your reply. You are completely right. Thank you very much again, |
I see, thanks for raising the issue in fieldtrip then! Good luck with your data curation. |
@JonathanVHoecke I actually think you closed your issue prematurely, you have a valid point. As we can see from your screenshot, the data includes all of the required columns. However, bids-validator only checks the first columns in your data and throws an error if the first columns are not all required columns, i.e. it is order-sensitive. However, the BIDS iEEG specification (to my knowledge) actually does not make any statements about the actual order of the columns. This is in contrast to the EEG specification which actually makes this statement:
I think at this moment this behavior of bids-validator is not absolutely correct. Also, ideally the error message should be more precise, e.g.
@sappelhoff What do you think is the way forward here, and am I missing anything? I think ideally, one would:
|
True, that was a shortcoming that has been fixed in the current development version that will soon be released, see:
Agreed.
Also true, this has been fixed in the current development version as well (see link above)
I think all issues you pointed out except the "misleading" validator error message have been fixed. Regarding the validator message, I guess a PR would be welcome, but we'd need a volunteer who first thinks more deeply about this issue, weighs pros and cons, and then suggests a concrete proposal how to fix it. I don't have time for that (currently) unfortunately. If neither of you two have time either, then perhaps raising an issue would be fine enough for now, so that in the future somebody can solve this. |
Thanks for clarifying, I am glad to hear that this has been solved already! |
Thank you very much @sappelhoff for your clarification. |
Dear Bids Validator developers,
According to the BIDSv1.6.0 the only column names that are compulsory in the channels.tsv are "name", "type" and "units" (in this order).
However, it seems like that the current BIDS Validator requires the 4th and the 5th column to be "low_cutoff" and "high_cutoff". I think this is a mistake, isn't it?
https://bids-specification.readthedocs.io/en/stable/04-modality-specific-files/03-electroencephalography.html#example-channelstsv
Thank you for your help,
Best wishes
on behalf of the ICN lab from Charité Berlin
The text was updated successfully, but these errors were encountered: