Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HED module incorrectly reports HED_VERSION_NOT_DEFINED warning on HED tests #2170

Closed
happy5214 opened this issue Oct 23, 2024 · 1 comment · Fixed by #2174
Closed

HED module incorrectly reports HED_VERSION_NOT_DEFINED warning on HED tests #2170

happy5214 opened this issue Oct 23, 2024 · 1 comment · Fixed by #2174
Assignees
Labels

Comments

@happy5214
Copy link
Collaborator

The tests have improperly nested HED data in three sidecars (the HED level is the third level, where it should be the second level). This is causing https://github.com/hed-standard/hed-javascript/blob/916236a58b9912cb4fefc0e79aa9c28d0f35cedb/bids/types/json.js#L107 to (correctly) throw an IssueError for what amounts to a SIDECAR_INVALID HED error. However, the try block starting at

incorrectly assumes all caught errors are missing schema errors, leading to improper issue reporting.

The tests need to be fixed to correct the level of HED in the three bad test sidecars, and hed.js needs to be re-coded to find another way to deal with a null return from the validation function.

Originally posted by @happy5214 in #2167 (comment)

@happy5214
Copy link
Collaborator Author

Please assign this to me. I plan to work on this in the next day or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants