Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules: add png and tif to [i|m]eeg #1443

Merged
merged 2 commits into from
Apr 15, 2022

Conversation

sappelhoff
Copy link
Member

should be merged after bids-standard/bids-specification#1049 has been merged.

@@ -77,6 +77,8 @@
"_meg.json",
"_coordsystem.json",
"_photo.jpg",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we should have a separate PR to escape all these dots...

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #1443 (fbc3b9a) into master (9c27673) will not change coverage.
The diff coverage is n/a.

❗ Current head fbc3b9a differs from pull request most recent head 3a9a4ab. Consider uploading reports for the commit 3a9a4ab to get more accurate results

@@           Coverage Diff           @@
##           master    #1443   +/-   ##
=======================================
  Coverage   84.02%   84.02%           
=======================================
  Files          90       90           
  Lines        3650     3650           
  Branches     1109     1109           
=======================================
  Hits         3067     3067           
  Misses        489      489           
  Partials       94       94           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c27673...3a9a4ab. Read the comment docs.

@effigies effigies merged commit b616bd1 into bids-standard:master Apr 15, 2022
@sappelhoff sappelhoff deleted the png/tif/imeeg branch May 20, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants