-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Excluded participants / runs #28
Comments
I would probably do this by adding a column in |
This would probably work, but I see some issues with that. Mainly, that to know who was actually excluded you would need to go check the file/s. For the participants it's just one file, which is ok, but for the runs it's many files... Might be better to have an explicit way of indicating that, or at least indicating the rule by which this was decided. For example, it's common to exclude runs with more than x% of volumes with FD values or other values above a certain threshold. Would be nice to specify that somehow in the bsm json file, even if it can't actually do the computation (though ideally of course it would also perform the computations with the transformations). |
Sounds like the job for another utility that can read in a confounds file for each participant and write out/modify a |
+1. I think as far as BIDS Stats Models is concerned, as long as you can specify your inputs, we've done our job. That said, I also agree w/ @rotemb9 that this is a common enough workflow that we should document what best-practice procedure looks like. |
I can see the appeal of adding an "Exclude" directive for sure. Again though, the StatsModels goal is not to be easy to edit by hand. We sort of already gave up on that since its always going to be hard to edit. I think as long as the model is explicit, another tool could make it easy to "Exclude" participants, and then generate the appropriate list of "Inputs". The problem with having "Exclude" is it adds complexity to the spec and implementations. That said, I could see that certain cases such as this are common enough that it could be worth it, so I'm not 100% again, just think if we can solve it with a tool that writes models that would be better. |
Older versions of the model had those, I think.
Would be nice to maybe be able to specify this though...
Otherwise transformers would have to be used to algorithmically exclude participants based on motion or something?
Tagging @rotemb9
The text was updated successfully, but these errors were encountered: