Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator: For contrasts, the number of weights should be equal the number of conditions #41

Open
Remi-Gau opened this issue May 20, 2022 · 2 comments

Comments

@Remi-Gau
Copy link
Contributor

The following should be invalid

      "Contrasts": [
        {
          "Name": "incongruent_vs_congruent",
          "ConditionList": ["incongruent", "congruent"],
          "Weights": [1, -1, 1],
          "Test": "t"
        }
      ]
@effigies
Copy link
Contributor

I don't know if we can impose this in general, since x_* would mean we don't know the number of conditions to check against. But in general I agree. Is it possible to do this in JSON validation or would it be purely in Python?

QQ: For F tests, I believe it's the case that the columns are supposed to match number of conditions, right? And is it the case that nrows <= ncols?

@Remi-Gau
Copy link
Contributor Author

I don't know if we can impose this in general, since x_* would mean we don't know the number of conditions to check against.

true: to a certain extend the fine detail would have to be done on the implementation side, but in any case one would need to know what weight to give each condition so even for a globbing parttern there should something that will be applied for all conditions that would result from it.

But in general I agree. Is it possible to do this in JSON validation or would it be purely in Python?

No idea.

QQ: For F tests, I believe it's the case that the columns are supposed to match number of conditions, right?

yup

And is it the case that nrows <= ncols?

yup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants