Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vanity/Nice URL for rooms? #1057

Closed
gilou opened this issue Mar 21, 2020 · 28 comments
Closed

Vanity/Nice URL for rooms? #1057

gilou opened this issue Mar 21, 2020 · 28 comments

Comments

@gilou
Copy link

gilou commented Mar 21, 2020

Hi,
Is it possible/simple to let users choose the URL of the room? The default could maybe be improved to user-room-urlified-name (I guess you want a bit of privacy, but well), but if there's no conflict we could let them choose what they want? or allow admin (or other role) to create a set of rooms with clear names?

I haven't looked at the code yet, I'm just relaying a request from users of a non-profit I installed GL/BBB for!

Cheers,
Gilou

@gilou
Copy link
Author

gilou commented Mar 21, 2020

I'm imagining the random uid is generated here:

self.uid = random_room_uid
and the 3 userchunk-xxx-xxx part is here:
# Generates a random room uid that uses the users name.
def random_room_uid
[owner.name_chunk, uid_chunk, uid_chunk].join('-').downcase
end

It seems that it's then used properly through the model everywhere, so that must just be a nice URL for RoR to play with? And if we change that, it should have no impact on previously created rooms.

Could be: sort of name-chunk for the name of the room, or a function to make the room name url compliant by default?

@farhatahmad
Copy link
Collaborator

Is it possible/simple to let users choose the URL of the room?

Not at the moment. Allowing the users to set their own room ids is tricky from the user experience point of view. It wouldn't be too hard to implement, but I'm not sure if this is something we would want to do.

I'm imagining the random uid is generated here:

Yes that's correct

so that must just be a nice URL for RoR to play with?

Not necessarily. The uid could be set to anything as long as it's unique. We originally chose to use that format and just never thought about the idea of changing it

@gilou
Copy link
Author

gilou commented Mar 23, 2020

OK, it has been pointed out at least once, but I get it, let's not worry about it for now!
Thanks for your feedback, and thank for GL/BBB !

@gilou gilou closed this as completed Mar 23, 2020
@Socob
Copy link

Socob commented Mar 29, 2020

I would second this request; it’s a common feature in other conferencing services. Sure, it’s very low priority, but the issue should be left open as long as it’s requested by users and not addressed (either by implementation or a WONTFIX/note in the documentation).

@gilou
Copy link
Author

gilou commented Mar 31, 2020

OK, let's keep it open then!

I'll look into it, there are ways to do that nicely I'm sure...

@kkplein
Copy link

kkplein commented Apr 4, 2020

Wanted to ask the same question. :-) If there are doubts about allowing users to change room names, how about making it an admin feature?
In the admin screen, Server Rooms, an ID edit-button would allow the creation of some nice institutional rooms, while keeping the rest of the software / user interface untouched.

@mrkeksi
Copy link
Contributor

mrkeksi commented Apr 7, 2020

I also ask for a primary school. The link is very easy to share via email but not every student gets the email on his mobile phone. So they have to type in the code. Is it not possible to have a word generator? Something like tree house, plant house, house stone, tree green. Just meaningless any words.

@farhatahmad
Copy link
Collaborator

Just a heads up, this can be done manually at the moment.

Running the commands below while replacing CURRENT_ROOM_ID with the current uid (eg ahm-a13-123) and NEW_CUSTOM_ID with the new uid you want (eg test-room) will change your url from https://greenlight-hostname/b/ahm-a13-123 to https://greenlight-hostname/b/test-room

docker exec -it greenlight-v2 bash
bundle exec rails c
Room.find_by(uid: "CURRENT_ROOM_ID").update_attribute(:uid, "NEW_CUSTOM_ID")

@kkplein
Copy link

kkplein commented Apr 7, 2020

Thanks for that suggestion! Appreciated. We will try it. Would be nice if it could be added to the (perhaps admin only) user interface though.

@EnzoBitMatrix
Copy link

Just a heads up, this can be done manually at the moment.

Running the commands below while replacing CURRENT_ROOM_ID with the current uid (eg ahm-a13-123) and NEW_CUSTOM_ID with the new uid you want (eg test-room) will change your url from https://greenlight-hostname/b/ahm-a13-123 to https://greenlight-hostname/b/test-room

docker exec -it greenlight-v2 bash
bundle exec rails c
Room.find_by(uid: "CURRENT_ROOM_ID").update_attribute(:uid, "NEW_CUSTOM_ID")

This is a perfect workaround until a decision is made on doing this from the frontend! Thanks.

@Balbuto
Copy link

Balbuto commented Apr 30, 2020

Just a heads up, this can be done manually at the moment.
Running the commands below while replacing CURRENT_ROOM_ID with the current uid (eg ahm-a13-123) and NEW_CUSTOM_ID with the new uid you want (eg test-room) will change your url from https://greenlight-hostname/b/ahm-a13-123 to https://greenlight-hostname/b/test-room
docker exec -it greenlight-v2 bash
bundle exec rails c
Room.find_by(uid: "CURRENT_ROOM_ID").update_attribute(:uid, "NEW_CUSTOM_ID")

This is a perfect workaround until a decision is made on doing this from the frontend! Thanks.

Is this work for rooms with non-english lang naming (CUSTOM_ID)?

@keunes
Copy link

keunes commented May 26, 2020

Allowing the users to set their own room ids is tricky from the user experience point of view.

I custom room names would be superhelpful (even if not high priority). Not sure why it would be tricky or complicated to get the UX right? By default rooms get a random url. Add a button 'Customise URL' (simliarly to the access code button) and once clicked allow users to set a custom url.

@farhatahmad
Copy link
Collaborator

That comment was made 3 months ago before the introduction of some of the intermediate things that was required to get this. The first step (which was done in 2.5.5 or 2.5.6) was to make room options configurable by admins. Since this is a feature that would need to be configurable, I had to wait until that was done before I can take a look at this

@gilou
Copy link
Author

gilou commented Nov 3, 2020

Hi, I'm available to get back on that, so I'll get back at the drawing board, unless there are some development regarding this feature?

@kkplein
Copy link

kkplein commented Feb 4, 2021

Hi @gilou. Any update on this? The feature would be so welcome :-)

@gilou
Copy link
Author

gilou commented Feb 4, 2021

Hi, not at all…

I can start drafting, and maybe github is not the channel for it, but the mailing-list, I do not know.

My idea:

  • add a permission to set a room's uid
  • if you have that permission, you can change (or maybe even decide at creation) the room name
  • upon modification, we check if there is no colliding room name before allowing the change

and maybe:

  • add a regexp pattern for allowed names ?
  • allow for a different scheme for random uid names?

@kkplein
Copy link

kkplein commented Feb 4, 2021

Sounds perfect to us..! Since there is also a room name, perhaps the proposed url could be: room name without spaces, as long as that doesn't result in a conflict...?

@FreeScholar
Copy link

I love this idea. Hope it happens soon! Thanks for the hard thinking on it:)

@andreas-bulling
Copy link

same

@andreas-bulling
Copy link

Just a heads up, this can be done manually at the moment.

Running the commands below while replacing CURRENT_ROOM_ID with the current uid (eg ahm-a13-123) and NEW_CUSTOM_ID with the new uid you want (eg test-room) will change your url from https://greenlight-hostname/b/ahm-a13-123 to https://greenlight-hostname/b/test-room

docker exec -it greenlight-v2 bash
bundle exec rails c
Room.find_by(uid: "CURRENT_ROOM_ID").update_attribute(:uid, "NEW_CUSTOM_ID")

Just to make sure before I try it out: This doesn't break anything because the id is used elsewhere internally?

@gilou
Copy link
Author

gilou commented May 5, 2021

Just to make sure before I try it out: This doesn't break anything because the id is used elsewhere internally?

It works, and only "breaks" the former links, obviously.
I'm still considering that feature, though other priorities have arisen…

@Nick64M
Copy link

Nick64M commented Dec 19, 2021

Please help: I want to change the link in greenlight, and the result is an error
root@lms:~# docker exec -it greenlight-v2 bash bundle exec rails c Room.find_by(uid:"nic-7bw-1fy-elv").update_attribute(:uid,"LannaVOKMS")
-bash: syntax error near unexpected token `('

@kkplein
Copy link

kkplein commented Dec 19, 2021

I have separate lines to type in my records:

sudo docker exec -it greenlight-v2 bash
bundle exec rails c
Room.find_by(uid: "CURRENT_ROOM_ID").update_attribute(:uid, "NEW_CUSTOM_ID")

@gilou
Copy link
Author

gilou commented Dec 19, 2021

Please help: I want to change the link in greenlight, and the result is an error root@lms:~# docker exec -it greenlight-v2 bash bundle exec rails c Room.find_by(uid:"nic-7bw-1fy-elv").update_attribute(:uid,"LannaVOKMS") -bash: syntax error near unexpected token `('

Use the code blocks in github so we can see better what you typed. If you typed it all in one line, it won't work, as it's 2 step (as mentionned by @kkplein :

  • bundle exec rails c : that will launch a rails console to use on greenlight
  • Room.find_by(uid:"nic-7bw-1fy-elv").update_attribute(:uid,"LannaVOKMS") inside that new shell (prompt will be different).

@Nick64M
Copy link

Nick64M commented Dec 20, 2021

Thanks for the help! Got it! All in 3 lines:

  • docker exec -it greenlight-v2 bash
  • bundle exec rails c
  • Room.find_by(uid:"nic-7bw-1fy-elv").update_attribute(:uid,"LannaVOKMS")
    result:
    => true
    irb(main):002:0> exit
    bash-5.1# exit
    exit
    root@lms:~# cd /greenlight
    root@lms:
    /greenlight# docker-compose down


root@lms:~/greenlight# docker-compose up -d


@hadicheaito1
Copy link
Contributor

Hello! Unfortunately, we will not be able to devote time into this feature/enhancement request at the moment due to our attention being directed towards Greenlight v3!
If this is something you believe that will be beneficial to v3, then we encourage you to please re-create this request once v3 is up and running.

To find out more information on Greenlight v3, please click the following link:
https://groups.google.com/g/bigbluebutton-dev/c/1nG-k_iTHjo

Thanks for your continued support!

@erpsolns
Copy link

erpsolns commented Apr 12, 2022

Hi it used to work for me but I newly installed bbb (with greenlight) - bbb 2.5 alpha5 and later tested alpha 6 - But cant change the room url root@ns539621:~# docker exec -it greenlight-v2 bash
bash-5.1# bundle exec rails c
warning: parser/current is loading parser/ruby27, which recognizes
warning: 2.7.2-compliant syntax, but you are running 2.7.5.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.
Loading production environment (Rails 5.2.6.3)
irb(main):001:1> Room.find_by(uid:"sai-anz-p90-be5").update_attribute(:uid,”sai-
0j6-3ul-i0u”
irb(main):002:1> Room.find_by(uid:"sai-anz-p90-be5").update_attribute(:uid,”sa
i-0j6-3ul-i0u”)
irb(main):003:1>

and not going any further. no change of url effected

@PhoenixSmaug
Copy link

Version 2.6 uses Greenlight v3 with a different system for room codes. To manually change it here use the following:

docker exec -it greenlight-v3 bash
bundle exec rails c
Room.find_by(friendly_id: "CURRENT_ROOM_ID").update_attribute(:friendly_id, "NEW_CUSTOM_ID")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests