Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): restyle and rearrange sidenav #151

Merged
merged 5 commits into from
Aug 13, 2019
Merged

fix(docs): restyle and rearrange sidenav #151

merged 5 commits into from
Aug 13, 2019

Conversation

chanceaclark
Copy link
Contributor

@chanceaclark chanceaclark commented Aug 12, 2019

What

  • Restyled side nav
  • Updated links to next links
  • Added Beta badge

Screenshot

screencapture-localhost-3000-2019-08-13-12_46_30

@chanceaclark chanceaclark requested a review from a team August 12, 2019 21:10
Copy link
Member

@deini deini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BETA badge seems a bit off in position 🤔 should we place it somewhere else?

packages/big-design-theme/src/system/display.ts Outdated Show resolved Hide resolved
packages/big-design/src/components/Link/Link.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@jorgemoya jorgemoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Only needs to address other comments.

@chanceaclark
Copy link
Contributor Author

@deini Where were you thinking the BETA badge would be?

@deini
Copy link
Member

deini commented Aug 13, 2019

@chanceaclark Not sure, but it seems odd @stevenbennitt thoughts?

@stevenbennitt
Copy link
Contributor

@chanceaclark I like it! Only thing that crossed my mind was if it should be on the top?
Also, should I use that same color for my label found here?
https://developer-beta.bigcommerce.com/tools-resources?__build_id=37521

@stevenbennitt
Copy link
Contributor

@deini @chanceaclark We could also do the same kind of banner that Im using in the upper left or right of the site page too?

@deini
Copy link
Member

deini commented Aug 13, 2019

@stevenbennitt The banner is not a big-design pattern so I rather use an existing pattern.

@chanceaclark
Copy link
Contributor Author

I agree with @deini. And we removed the primary color for badges so it would have to be an extended styled components if we wanted to match colors rather than uses what's out of the box.

@stevenbennitt
Copy link
Contributor

stevenbennitt commented Aug 13, 2019

@chanceaclark @deini makes sense to me! The more I look at it, it does seem a little out of place underneath the logo, seems like we're typically using it inline in other places but that doesn't really make sense here due to limited space.

@chanceaclark
Copy link
Contributor Author

@stevenbennitt @deini alright changed the beta badge to a ribbon in the top right. Will not show for mobile. See screenshot above ^

Copy link
Member

@deini deini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑

@chanceaclark chanceaclark merged commit 1be86d1 into bigcommerce:master Aug 13, 2019
@chanceaclark chanceaclark deleted the docs/polish-sidenav branch August 13, 2019 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants