-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): restyle and rearrange sidenav #151
fix(docs): restyle and rearrange sidenav #151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The BETA
badge seems a bit off in position 🤔 should we place it somewhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Only needs to address other comments.
@deini Where were you thinking the BETA badge would be? |
@chanceaclark Not sure, but it seems odd @stevenbennitt thoughts? |
@chanceaclark I like it! Only thing that crossed my mind was if it should be on the top? |
@deini @chanceaclark We could also do the same kind of banner that Im using in the upper left or right of the site page too? |
@stevenbennitt The banner is not a big-design pattern so I rather use an existing pattern. |
I agree with @deini. And we removed the primary color for badges so it would have to be an extended styled components if we wanted to match colors rather than uses what's out of the box. |
@chanceaclark @deini makes sense to me! The more I look at it, it does seem a little out of place underneath the logo, seems like we're typically using it inline in other places but that doesn't really make sense here due to limited space. |
@stevenbennitt @deini alright changed the beta badge to a ribbon in the top right. Will not show for mobile. See screenshot above ^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐑
What
Screenshot