Restrict Dropdown #212
Merged
Restrict Dropdown #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should all the options use a pointer cursor? 🤔 |
Let me consult with design. |
deini
reviewed
Oct 16, 2019
| }); | ||
| private renderIcon(icon: React.ReactNode, isHighlighted: boolean, option: DropdownItem | DropdownLinkItem) { | ||
| return ( | ||
| React.isValidElement(icon) && |
There was a problem hiding this comment.
Can we add a check to make sure the type is icon?
| id={id} | ||
| key={index} | ||
| onClick={() => this.handleOnItemClick(option)} | ||
| onFocus={this.handleOnItemFocus} |
There was a problem hiding this comment.
Should onFocus and onMouseOver call the same fn?
|
|
||
| interface BaseItem extends Omit<ListItemProps, 'children' | 'content' | 'onClick' | 'value'> { |
There was a problem hiding this comment.
Can you move the BaseItem definition before DropdowItem and DropdownLinkItem 🙏
| <Dropdown.Item value={2}>Option</Dropdown.Item> | ||
| <Dropdown.Item value={3}>Option</Dropdown.Item> | ||
| </Dropdown> | ||
| <Dropdown |
There was a problem hiding this comment.
🍹
<Dropdown
options={[
{ content: 'Option', type: 'string', value: '0' },
{ content: 'Option', type: 'string', value: '1', onClick },
{ content: 'Option', type: 'string', value: '2', actionType: 'destructive' },
{ content: 'Option', type: 'string', value: '3', icon: <CheckCircleIcon /> },
]}
trigger={<Button>Button</Button>}
/>| { content: 'Option', url: '#', type: 'link' }, | ||
| ]} | ||
| trigger={<Button>Button</Button>} | ||
| ></Dropdown>, |
| > | ||
| {option.type === 'link' && !option.disabled ? ( | ||
| <Link href={option.url} target={option.target}> | ||
| <Flex alignItems="center"> |
There was a problem hiding this comment.
Suggested change
| <Flex alignItems="center"> | |
| <Flex alignItems="center" flexDirection="row"> |
| </Flex> | ||
| </Link> | ||
| ) : ( | ||
| <Flex alignItems="center"> |
deini
approved these changes
Oct 17, 2019
chanceaclark
approved these changes
Oct 17, 2019
jorgemoya
force-pushed
the
restrict-dropdown
branch
from
dc87104
to
8d33ae4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new
optionsprop that will restrict the usage of the items. TheonClickfor each item with return theitemitself. No need to usedata-valueanymore.Now also accepts
iconsas a DropdownItem prop.Wasn't sure how to document the new
DropdownItemandDropdownLinkItem. Feedback pls 🙏 .