feat(component): add filterable prop to Select #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgemoya
commented
Oct 29, 2019
Comment on lines
+47
to
+49
| label { | ||
| cursor: ${({ disabled }) => (disabled ? 'not-allowed' : 'pointer')}; | ||
| } |
There was a problem hiding this comment.
This is needed, so I added it back.
| @@ -120,7 +131,7 @@ export class Select<T extends any> extends React.PureComponent<SelectProps<T>, S | |||
| } | |||
|
|
|||
| private renderInput() { | |||
| const { placeholder, error, required, disabled, onChange, options, value } = this.props; | |||
| const { placeholder, error, filterable = true, required, disabled, onChange, options, value } = this.props; | |||
There was a problem hiding this comment.
Is this the best way to set a default? Not sure when to use defaultProps or just default like this.
There was a problem hiding this comment.
It should be fine. In this case since the prop is at the class level, it might be better to add it onto defaultProps. That way undefined doesn't get passed through the component.
chanceaclark
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionality will remain the same by default, but now it can be set to
falseto prevent input filtering.Misc:
Added back the
labelstyling rule, it was actually needed.