Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add react-hooks eslint and fix missing deps/issues #330

Merged
merged 1 commit into from
Jan 21, 2020
Merged

fix: add react-hooks eslint and fix missing deps/issues #330

merged 1 commit into from
Jan 21, 2020

Conversation

chanceaclark
Copy link
Contributor

What

Add react-hooks eslint plugin and fix missing dependencies. Also fixed some logic around custom hooks.

@chanceaclark chanceaclark requested a review from a team January 20, 2020 20:57
rtalvarez
rtalvarez approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@rtalvarez rtalvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of missing newlines on some of the new files but other than that lgtm

@chanceaclark
Copy link
Contributor Author

a couple of missing newlines on some of the new files but other than that lgtm

Locally they have newlines 😖

@rtalvarez
Copy link
Member

a couple of missing newlines on some of the new files but other than that lgtm

Locally they have newlines 😖

:fake-news:

deini
deini approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@deini deini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@chanceaclark chanceaclark merged commit da3fbd6 into bigcommerce:master Jan 21, 2020
@chanceaclark chanceaclark deleted the eslint-config branch January 21, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deini deini deini approved these changes

@rtalvarez rtalvarez rtalvarez approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chanceaclark @rtalvarez @deini