feat(component): add Alerts, InlineAlerts, and Message components #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deini
reviewed
Feb 17, 2020
chanceaclark
force-pushed
the
feat/alerts
branch
from
b1fda6f
to
5f12d71
Compare
golcinho
reviewed
Feb 18, 2020
deini
reviewed
Feb 18, 2020
|
Can you add some screenshots of the PR? |
chanceaclark
force-pushed
the
feat/alerts
branch
from
96b490f
to
db8b05d
Compare
chanceaclark
changed the title
deini
reviewed
Feb 19, 2020
|
|
||
| useEffect(() => manager.subscribe(setAlert), [manager]); | ||
|
|
||
| return <>{alert && <Alert {...alert} />}</>; |
There was a problem hiding this comment.
🍹
Suggested change
| return <>{alert && <Alert {...alert} />}</>; | |
| return alert ? <Alert {...alert} /> : null; |
rtalvarez
reviewed
Feb 19, 2020
chanceaclark
force-pushed
the
feat/alerts
branch
2 times, most recently
from
807697c
to
64654ab
Compare
chanceaclark
force-pushed
the
feat/alerts
branch
from
64654ab
to
a80924e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add
Alerts,InlineAlerts, andMessages.Screenshots