-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(component): add Alerts, InlineAlerts, and Message components #340
Conversation
b1fda6f
to
5f12d71
Compare
Can you add some screenshots of the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
96b490f
to
db8b05d
Compare
|
||
useEffect(() => manager.subscribe(setAlert), [manager]); | ||
|
||
return <>{alert && <Alert {...alert} />}</>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍹
return <>{alert && <Alert {...alert} />}</>; | |
return alert ? <Alert {...alert} /> : null; |
807697c
to
64654ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
64654ab
to
a80924e
Compare
What
Add
Alerts
,InlineAlerts
, andMessages
.Screenshots