feat(component): adds grouping options to Select component #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why |
My guess is this is the |
jorgemoya
reviewed
Mar 24, 2020
added 5 commits
March 26, 2020 12:26
jordan-massingill
changed the title
packages/big-design/src/components/List/GroupHeader/ListGroupHeader.tsx
Outdated
Show resolved
Hide resolved
jorgemoya
approved these changes
Apr 1, 2020
chanceaclark
approved these changes
Apr 1, 2020
Comment on lines
+296
to
+300
| if ( | ||
| !selectOptions.find( | ||
| (option: SelectOption<T> | SelectAction) => 'value' in option && option.value === item.value, | ||
| ) | ||
| ) { |
There was a problem hiding this comment.
🍹🍹🍹
Suggested change
| if ( | |
| !selectOptions.find( | |
| (option: SelectOption<T> | SelectAction) => 'value' in option && option.value === item.value, | |
| ) | |
| ) { | |
| if (!selectOptions.find(option => 'value' in option && option.value === item.value)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to recently updated Dropdown component, adds ability to create groups in a Select component with labels.