feat(component): rename popover offset props and defaults #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
deini
commented
Sep 1, 2020
deini
commented
- Make Popover and Tooltips have the same default offset as dropdowns.
- Rename offset props for Popover
chanceaclark
approved these changes
Sep 1, 2020
rtalvarez
reviewed
Sep 1, 2020
| types: 'number', | ||
| defaultValue: '0', | ||
| description: 'Determines the popover offset on the X axis.', | ||
| description: 'Determines the offset along the anchorElement.', | ||
| }, | ||
| { | ||
| name: 'offsetY', |
There was a problem hiding this comment.
Should you rename this to distance also?
rtalvarez
reviewed
Sep 1, 2020
| types: 'number', | ||
| defaultValue: '0', | ||
| description: 'Determines the popover offset on the X axis.', | ||
| description: 'Determines the offset along the anchorElement.', |
There was a problem hiding this comment.
🍹 I'd specify the direction of the offset, eg for skidding Determines the horizontal offset along the anchorElement
and for distance I'd say Determines the vertical offset along the anchorElement. I think it's a bit more clear
There was a problem hiding this comment.
In this case, there is no concept of horizontal/vertical since a Popover can be placed in any direction (top, right, etc).
jorgemoya
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.