feat(docs): update stateful tree page to use new layout #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanceaclark
commented
Oct 6, 2021
| @@ -10,7 +10,7 @@ export const useContentRoutingTabs = (routes: Route[], id: string) => { | |||
| const activeContent = routes.find((content) => content.id === activePill); | |||
|
|
|||
| const handlePillClick = (pillId: string) => { | |||
| push({ query: { ...query, [id]: pillId } }, undefined, { shallow: true }); | |||
| push({ query: { ...query, [id]: pillId } }, undefined, { scroll: false, shallow: true }); | |||
There was a problem hiding this comment.
Added scroll: false to ensure we don't scroll when switching content.
| @@ -12,7 +12,7 @@ function getLinkAs(as = '') { | |||
| return prefix + as; | |||
| } | |||
|
|
|||
| export const NextLink: React.FC<{ href: string; as?: string }> = (props) => { | |||
| export const NextLink: React.FC<{ href: LinkProps['href']; as?: string }> = (props) => { | |||
There was a problem hiding this comment.
Duplicated from #606
jorgemoya
approved these changes
Oct 7, 2021
rtalvarez
approved these changes
Oct 7, 2021
jorgemoya
reviewed
Oct 7, 2021
chanceaclark
force-pushed
the
docs/update-stateful-tree
branch
2 times, most recently
from
279be3a
to
792695f
Compare
chanceaclark
force-pushed
the
docs/update-stateful-tree
branch
from
b4b7a77
to
1654e9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates
StatefulTreepage to use new layout.Screenshots/Screen Recordings
Testing/Proof
N/A