Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(component): allow custom column widths and overflow worksheet #975

Merged
merged 2 commits into from
Sep 20, 2022
Merged

feat(component): allow custom column widths and overflow worksheet #975

merged 2 commits into from
Sep 20, 2022

Conversation

jorgemoya
Copy link
Contributor

@jorgemoya jorgemoya commented Sep 19, 2022 •
edited
Loading

What?

Breaking changes (??)

  • Allow custom widths to Worksheet columns.
  • Scrollable overflow when columns are wider than table view.
  • Columns wont ellipsis anymore, instead words will wrap.
  • When all columns have a fixed width, set Worksheet to auto width (instead of 100%).

Screenshots/Screen Recordings

Before:
Kapture 2022-09-19 at 16 32 16

After:
Screen Shot 2022-09-19 at 3 56 10 PM

Kapture 2022-09-19 at 16 20 34

All columns are fixed width:
Screen Shot 2022-09-19 at 4 22 27 PM

At least one column is auto:
Screen Shot 2022-09-19 at 4 23 19 PM

Testing/Proof

Locally, added unit tests.

@jorgemoya jorgemoya requested review from a team as code owners September 19, 2022 21:26
chanceaclark
chanceaclark approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@chanceaclark chanceaclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jorgemoya
Copy link
Contributor Author

Found a small resizing bug when changing text in cells, I'm 👀 .

@jorgemoya jorgemoya merged commit 272dc39 into bigcommerce:master Sep 20, 2022
@jorgemoya jorgemoya deleted the overflow-worksheet branch September 20, 2022 20:09
@jorgemoya jorgemoya mentioned this pull request Sep 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanceaclark chanceaclark chanceaclark approved these changes

@eugene-polev eugene-polev eugene-polev approved these changes

@markcmurphy markcmurphy Awaiting requested review from markcmurphy markcmurphy was automatically assigned from bigcommerce/dev-docs-team

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorgemoya @chanceaclark @eugene-polev