From 35cebc739ea24fd8864fd88ab85ceabbfede5702 Mon Sep 17 00:00:00 2001 From: David Payne Date: Thu, 7 Jun 2018 10:39:24 -0700 Subject: [PATCH] fix(content): STRF-4948 fix missing svg icons on AMP add-to-cart page by generating an template file that contains the assets --- CHANGELOG.md | 1 + assets/icons/instagram.svg | 2 +- assets/icons/stumbleupon.svg | 6 +++--- assets/img/icon-sprite.svg | 2 +- grunt/svgstore.js | 3 ++- templates/components/amp/common/icon-defs.html | 1 + templates/layout/amp-iframe.html | 2 +- 7 files changed, 10 insertions(+), 7 deletions(-) create mode 100644 templates/components/amp/common/icon-defs.html diff --git a/CHANGELOG.md b/CHANGELOG.md index b0059ac1e3..635dcdfcb4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ - Fix empty image on carousel wrap. [#1263](https://github.com/bigcommerce/cornerstone/pull/1263) - Fix duplicate IDs occurrence in product options in certain situations & syntax fix in bulk-discount-rates component [#1223](https://github.com/bigcommerce/cornerstone/pull/1223) - Fix use case that prevented retail/sale prices from displaying on product details page [#1262](https://github.com/bigcommerce/cornerstone/pull/1262) +- Fix svg arrows missing on AMP product pages. [#1258](https://github.com/bigcommerce/cornerstone/pull/1258) ## 2.1.0 (2018-06-01) - Add Newsletter summary section to subscription form. [#1248](https://github.com/bigcommerce/cornerstone/pull/1248) diff --git a/assets/icons/instagram.svg b/assets/icons/instagram.svg index ea1e431c6c..6baa2245e9 100644 --- a/assets/icons/instagram.svg +++ b/assets/icons/instagram.svg @@ -1,4 +1,4 @@ - + diff --git a/assets/icons/stumbleupon.svg b/assets/icons/stumbleupon.svg index 01d11d4c6f..4b95bcb860 100644 --- a/assets/icons/stumbleupon.svg +++ b/assets/icons/stumbleupon.svg @@ -3,8 +3,8 @@ - - + + - + diff --git a/assets/img/icon-sprite.svg b/assets/img/icon-sprite.svg index 0b30adbd4e..d5d659e722 100644 --- a/assets/img/icon-sprite.svg +++ b/assets/img/icon-sprite.svg @@ -1 +1 @@ - \ No newline at end of file + \ No newline at end of file diff --git a/grunt/svgstore.js b/grunt/svgstore.js index 2e71a91c8e..b2c4546c38 100644 --- a/grunt/svgstore.js +++ b/grunt/svgstore.js @@ -7,7 +7,8 @@ module.exports = { 'default': { files: { - './assets/img/icon-sprite.svg': ['./assets/icons/**/*.svg'] + './assets/img/icon-sprite.svg': ['./assets/icons/**/*.svg'], + './templates/components/amp/common/icon-defs.html': ['./assets/icons/**/*.svg'] } } }; diff --git a/templates/components/amp/common/icon-defs.html b/templates/components/amp/common/icon-defs.html new file mode 100644 index 0000000000..d5d659e722 --- /dev/null +++ b/templates/components/amp/common/icon-defs.html @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/templates/layout/amp-iframe.html b/templates/layout/amp-iframe.html index 50b5e5e12a..62fdb663b9 100644 --- a/templates/layout/amp-iframe.html +++ b/templates/layout/amp-iframe.html @@ -24,7 +24,7 @@ - +
{{> components/amp/common/icon-defs }}
{{#block "page"}} {{/block}}