From 7a344c7655a87b9cab652c3266864e8cb77deabc Mon Sep 17 00:00:00 2001 From: bc-annavu Date: Sun, 26 Mar 2017 17:32:31 -0700 Subject: [PATCH] Fix AMP Carousel on Product Page ### What? Restyled how product details are implemented on the product page. ### Why? When there are additional details on the product page, the amp carousel shrinks because of the way that the product details are styled. ### Proof/Testing --- templates/components/amp/css/base.html | 4 ---- templates/components/amp/css/product.html | 22 ++++++++-------------- 2 files changed, 8 insertions(+), 18 deletions(-) diff --git a/templates/components/amp/css/base.html b/templates/components/amp/css/base.html index c86fe13cb6..ecd4f23607 100644 --- a/templates/components/amp/css/base.html +++ b/templates/components/amp/css/base.html @@ -127,10 +127,6 @@ } dl dt { font-weight: 700; - margin-bottom: .35714rem -} -dl dd { - margin-bottom: 1.5rem } abbr, acronym { diff --git a/templates/components/amp/css/product.html b/templates/components/amp/css/product.html index d013fb9878..3bada342b4 100644 --- a/templates/components/amp/css/product.html +++ b/templates/components/amp/css/product.html @@ -117,7 +117,7 @@ width: 1px } .productView-details { - margin-bottom: 2rem + margin-bottom: 1rem } .productView-product >:last-child { margin-bottom: 0 @@ -152,24 +152,18 @@ .productView-info { margin-top: .78571rem } -.productView-info:before, -.productView-info:after { - content: " "; - display: table -} .productView-info >:last-child { margin-bottom: 0 } .productView-info-name, .productView-info-value { - float: left + display: inline; + margin: 0; } .productView-info-name { - clear: both; - margin-bottom: .21429rem; - margin-right: .35714rem + margin-right: 5px; +} +.productView-info-value::after { + content: "\A"; + white-space: pre; } -.productView-info-value { - margin-bottom: .35714rem; - margin-left: 0; -} \ No newline at end of file