Skip to content

Commit

Permalink
Merge pull request #1320 from Ubersmake/1290
Browse files Browse the repository at this point in the history
Changelog for #1290
  • Loading branch information
Ubersmake authored Aug 1, 2018
2 parents 0752150 + 3799032 commit 811c724
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
- Fix blog_post import statement in app.js [#1301](https://github.com/bigcommerce/cornerstone/pull/1301)
- Show carousel dots only when carousel has more than one slide. [#1319](https://github.com/bigcommerce/cornerstone/pull/1319)
- New products left align. [1321](https://github.com/bigcommerce/cornerstone/pull/1321)
- Fix initial aria attributes for 'Customers Also Viewed' products tab [#1290](https://github.com/bigcommerce/cornerstone/pull/1290)

## 2.2.1 (2018-07-10)
- Fix wishlist dropdown background color bleeding out of container [#1283](https://github.com/bigcommerce/cornerstone/pull/1283)
Expand Down
4 changes: 2 additions & 2 deletions templates/components/products/tabs.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
{{/if}}
{{#if product.similar_by_views}}
<li class="tab{{#unless product.related_products}} is-active{{/unless}}" role="presentational">
<a class="tab-title" href="#tab-similar" role="tab" tabindex="0" aria-selected="false" controls="tab-similar">{{lang 'products.similar_by_views'}}</a>
<a class="tab-title" href="#tab-similar" role="tab" tabindex="0" aria-selected="{{#if product.related_products}}false{{else}}true{{/if}}" controls="tab-similar">{{lang 'products.similar_by_views'}}</a>
</li>
{{/if}}
</ul>
Expand All @@ -19,7 +19,7 @@
{{/if}}

{{#if product.similar_by_views}}
<div role="tabpanel" aria-hidden="true" class="tab-content has-jsContent{{#unless product.related_products}} is-active{{/unless}}" id="tab-similar">
<div role="tabpanel" aria-hidden="{{#if product.related_products}}true{{else}}false{{/if}}" class="tab-content has-jsContent{{#unless product.related_products}} is-active{{/unless}}" id="tab-similar">
{{> components/products/carousel products=product.similar_by_views columns=6}}
</div>
{{/if}}
Expand Down

0 comments on commit 811c724

Please sign in to comment.