Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customer Order grid link issue. #1330

Closed
ghost opened this issue Aug 17, 2018 · 3 comments
Closed

Customer Order grid link issue. #1330

ghost opened this issue Aug 17, 2018 · 3 comments

Comments

@ghost
Copy link

ghost commented Aug 17, 2018

Expected behavior

Customer My Account Page

  • Order listing page showing order. when user go to order details order link will be order listing page.

Actual behavior

  • Now when user goto order listing page to order details. On order details Order tab is no link to go to order listing page.

Steps to reproduce the behavior

  • Place ann order
  • Goto order listing page.
  • Goto order detail pahe.
  • No link to goto order listing page.

Solution

Current Code

{{#if account_page '===' 'orders'}}<li class="navBar-item is-active">{{lang 'account.nav.orders'}}</li>{{else}}<li class="navBar-item"><a class="navBar-action" href="{{urls.account.orders.all}}">{{lang 'account.nav.orders'}}</a></li>{{/if}}

Solution Code
{{#if account_page '===' 'orders'}} {{#if page_type '===' 'account_order'}} <li class="navBar-item is-active"> <a class="navBar-action" href="{{urls.account.orders.all}}">{{lang 'account.nav.orders'}}</a> </li> {{else}} <li class="navBar-item is-active">{{lang 'account.nav.orders'}}</li> {{/if}} {{else}} <li class="navBar-item"> <a class="navBar-action" href="{{urls.account.orders.all}}">{{lang 'account.nav.orders'}}</a> </li> {{/if}}

@sacr3dc0w
Copy link
Contributor

sacr3dc0w commented Sep 9, 2018

Watching football and coding so I made a PR to implement this fix. #1343 Thanks for the solutions. Cheers!

@junedkazi junedkazi changed the title Customer Order grid link issuse. Customer Order grid link issue. Sep 21, 2018
@Ubersmake
Copy link
Contributor

Hi @hiteshvaghasiya83 . It looks like this was addressed in #1343, which was released as a part of Cornerstone 2.4.0: https://github.com/bigcommerce/cornerstone/releases/tag/2.4.0 . If this has addressed this issue, could you close it?

@Ubersmake
Copy link
Contributor

Hi @hiteshvaghasiya83 . I'm going to close this issue because of the fix in #1343 . Please reopen if it appears in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants