Product filters do not keep the previously selected color filter when the price filter is the top.

[anilgautamm]

Expected behavior

Product filters should preserve filters after range selection when price filter is the top.

Actual behavior

Product filters do not keep the previously selected color filter when the price filter is the top.

Steps to reproduce the behavior

when the price filter is the top.
https://www.useloom.com/share/f3bcb360539243beb01b6488d21f9e08

[Ubersmake]

First mentioned in #1232 (comment).

[HikeOn]

Hi,

The issue got resolved for us after we replaced the code

onRangeSubmit(event) {
event.preventDefault();
if (!this.priceRangeValidator.areAll(nod.constants.VALID)) {
return;
}
const url = Url.parse(window.location.href);
const queryParams = decodeURI($(event.currentTarget).serialize());
urlUtils.goToUrl(Url.format({ pathname: url.pathname, search: ?${queryParams} }));
}

in faceted-search.js file with

onRangeSubmit(event) {
event.preventDefault();
if (!this.priceRangeValidator.areAll(nod.constants.VALID)) {
return;
}
const url = Url.parse(window.location.href);
const avoidSearchQuery = 'search_query=';
const urlParams = new URLSearchParams(window.location.search);
const avoidSortValue = 'sort='+ urlParams.get('sort');
let queryParams = decodeURI($(event.currentTarget).serialize());
let path = url.path;
let urlValue;
if(path.indexOf('?') !== -1){
path = path.replace(avoidSortValue,'');
queryParams = queryParams.replace(avoidSortValue,'');
if(path.indexOf(avoidSearchQuery) !== -1){
if(urlParams.get('search_query') === null){
path = path.replace(avoidSearchQuery,'');
}else{
path = path.replace(avoidSearchQuery + urlParams.get('search_query') ,'');
}
if(path.indexOf(avoidSearchQuery+'&m') !== -1 || path.indexOf('&min_price') !== -1){
path = (path.indexOf(avoidSearchQuery+'&m') !== -1) ? path.replace(avoidSearchQuery+'&min_price='+urlParams.get('min_price')+'&max_price='+urlParams.get('max_price'),'') : path.replace('&min_price='+urlParams.get('min_price')+'&max_price='+urlParams.get('max_price'),'');
}
}
urlValue = path + &${queryParams};
urlValue = urlValue.replace(/&&[]=/g,'').replace(/&&*/g,'&').replace(/?&/g,'?');
if(urlParams.get('sort') !== null){
urlValue = urlValue + '&' + avoidSortValue;
}
}else{
urlValue = Url.format({ pathname: url.pathname, search: ?${queryParams} });
}
urlUtils.goToUrl(urlValue);
}

[Ubersmake]

This has been fixed in 3.4.1 as a part of #1471. This should be published to all stores within the next two weeks.